Auto close fetcher session #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfinkel
requested review from
cletomartin,
drsm79 and
mattwhite
as code owners
alfinkel
force-pushed
the
43-close-fetcher-session-object
branch
from
8849812 to
b010188
Compare
alfinkel
force-pushed
the
43-close-fetcher-session-object
branch
from
b010188 to
315434a
Compare
drsm79
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ensure that the fetcher session object is closed if it has been opened.
Why
Best practice...
How
In the tearDownClass - Check for session, if one exists, close it
Test
works in a virtualenvironment
Context